Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: email design review changes #1534

Merged
merged 2 commits into from
Aug 1, 2024
Merged

fix: email design review changes #1534

merged 2 commits into from
Aug 1, 2024

Conversation

gulfaraz
Copy link
Member

@gulfaraz gulfaraz commented Jul 26, 2024

Describe your changes

fixes #1512

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review

@gulfaraz gulfaraz added design This involves a design change dev This involves dev effort labels Jul 26, 2024
@gulfaraz gulfaraz requested a review from arsforza July 26, 2024 22:48
@gulfaraz
Copy link
Member Author

> test:api:all
> node --expose-gc node_modules/.bin/jest --config=jest.api.config.js --runInBand --detectOpenHandles --logHeapUsage

ts-jest[versions] (WARN) Version 4.9.5 of typescript installed has not been tested with ts-jest. If you're experiencing issues, consider using a supported version (>=2.7.0 <4.0.0). Please do not report issues in ts-jest if you are using unsupported versions.
 PASS  test/email/drought/email-uga-drought.test.ts (15.933s, 230 MB heap size)
  Should send an email for uga drought
    ✓ triggered in january (6446ms)
    ✓ non triggered any month (7667ms)

 PASS  test/email/floods/email-uga-floods.test.ts (31.759s, 232 MB heap size)
  Should send an email for uga floods
    ✓ default (8169ms)
    ✓ warning (7478ms)
    ✓ warning-to-trigger (7903ms)
    ✓ no-trigger (7887ms)

 PASS  test/email/floods/email-ssd-floods.test.ts (16.967s, 241 MB heap size)
  Should send an email for ssd floods
    ✓ default (8495ms)
    ✓ no-trigger (8236ms)

 PASS  test/email/typhoon/email-phl-typhoon.test.ts (12.079s, 249 MB heap size)
  Should send an email for phl typhoon
    ✓ default (11782ms)

Test Suites: 4 passed, 4 total
Tests:       9 passed, 9 total
Snapshots:   0 total
Time:        77.356s
Ran all test suites.

@arsforza arsforza merged commit 67a80d6 into master Aug 1, 2024
4 checks passed
@arsforza arsforza deleted the fix.email-design-review branch August 1, 2024 08:49
@gulfaraz gulfaraz mentioned this pull request Sep 29, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design This involves a design change dev This involves dev effort
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Design changes to alert emails
2 participants